Explicitly disconnect example app from domain upon window closing. #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
digisomni
added
CR approved
ctrlaltdavid
added
needs QA (testing)
and removed
do not merge
|
We'll merge this upon being fairly confident we've got most of the unhandled crash cases. |
|
I have been running this PR for the last few weeks and have been connecting and disconnecting multiple times with no crashes. |
|
We should retest web functionality on Linux and Windows to determine if any crashing is still present before merging this. If there is crashing present, then we should attach a debugger to either instance and solve it, then merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without explicitly disconnecting, the user's avatar remains visible in the domain for 20s or so until the domain server decides that the user hasn't been heard from for too long and so removes the avatar.
Previously: Prevented domain server crash when close or refresh SDK example app window while connected to domain server, though this has since been fixed in vircadia/vircadia-native-core#1429 .