Adding log messages and updating unit test cases

Signed-off-by: Vishesh Tanksale <vtanksale@nvidia.com>
visheshtanksale · Jun 27, 2024 · 7d0e252 · 7d0e252
1 parent 8f10948
commit 7d0e252
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 2 deletions.
diff --git a/internal/lm/nvml.go b/internal/lm/nvml.go
@@ -22,6 +22,8 @@ import (
 	"strconv"
 	"strings"
 
+	"k8s.io/klog/v2"
+
 	"github.com/NVIDIA/go-nvlib/pkg/nvpci"
 
 	spec "github.com/NVIDIA/k8s-device-plugin/api/config/v1"
@@ -222,6 +224,7 @@ func getModeForClasses(classes []uint32) string {
 	}
 	for _, class := range classes {
 		if class != classes[0] {
+			klog.Infof("Not all GPU devices belong to the same class %#06x ", classes)
 			return "unknown"
 		}
 	}

diff --git a/internal/resource/testing/resource-testing.go b/internal/resource/testing/resource-testing.go
@@ -51,7 +51,7 @@ func NewDeviceMock(migEnabled bool) *DeviceMock {
 		IsMigEnabledFunc:     func() (bool, error) { return migEnabled, nil },
 		IsMigCapableFunc:     func() (bool, error) { return migEnabled, nil },
 		GetMigDevicesFunc:    func() ([]resource.Device, error) { return nil, nil },
-		GetPCIClassFunc:      func() (uint32, error) { return 0x030000, nil },
+		GetPCIClassFunc:      func() (uint32, error) { return 0, nil },
 	}}
 	return &d
 }

diff --git a/tests/expected-output-mig-single.txt b/tests/expected-output-mig-single.txt
@@ -30,5 +30,5 @@ nvidia\.com\/gpu\.engines\.jpeg=[0-9]+
 nvidia\.com\/gpu\.engines\.ofa=[0-9]+
 nvidia\.com\/gpu\.slices\.gi=[0-9]+
 nvidia\.com\/gpu\.slices\.ci=[0-9]+
-nvidia\.com\/gpu\.mode=[unknown|compute|graphics]
+nvidia\.com\/gpu\.mode=[compute]
 nvidia\.com\/mps\.capable=[true|false]