capture and return errors in ConntrackDeleteFilters #1014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aroradaman
changed the title
aroradaman
force-pushed
the
conntrack-delete-return-error
branch
2 times, most recently
from
0bbe568
to
f486354
Compare
aroradaman
changed the title
aroradaman
force-pushed
the
conntrack-delete-return-error
branch
2 times, most recently
from
8bbb26a
to
ce9042d
Compare
aboch
reviewed
Sep 5, 2024
Signed-off-by: Daman Arora <aroradaman@gmail.com>
aroradaman
force-pushed
the
conntrack-delete-return-error
branch
from
ce9042d
to
e42e07d
Compare
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ConntrackDeleteFiltersdoes not capture and return errors for the actual netlink call to delete the flow entry.This PR captures the error and returns it.