Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise driver repackaging #687

Closed
vitaly-t opened this issue Dec 25, 2019 · 9 comments
Closed

Revise driver repackaging #687

vitaly-t opened this issue Dec 25, 2019 · 9 comments

Comments

@vitaly-t
Copy link
Owner

vitaly-t commented Dec 25, 2019

Revise the latest repackaging of everything in the driver, to see what effect, if any, it may have here.

🔥 🔥 🔥

@vitaly-t
Copy link
Owner Author

For now, making 10.4.0-beta0 available with the latest driver.

@vitaly-t
Copy link
Owner Author

vitaly-t commented Dec 30, 2019

Many changes are happening in the driver presently. I will revise it all when 17.x reaches its end. For now, there's 10.4.0-beta.1 update.

You can install the latest beta via:

npm i pg-promise@beta

@vitaly-t
Copy link
Owner Author

vitaly-t commented Jan 11, 2020

While the driver continues to undergo changes that do not inspire confidence, I continue the corresponding updates within versions 10.4.0-beta.x, with 10.4.0-beta.3 being the latest.

Here's just the latest issue that I encountered.

I would urge anyone using it in production to stay away from the beta versions. They can be flimsy, especially in relation to data streaming. Stick to the officially released versions only.


I am doing my best to shield developers from any unreliable updates in the driver. 😄

@vitaly-t
Copy link
Owner Author

vitaly-t commented Jan 12, 2020

After everything, I am beginning to think that 10.4.0 won't see the light of day, the way it was intended. If anything, it will be v11.0.0 to take all those humongous changes in the driver, leaving v10 carrying on without ever updating the driver.

Version 10 is very robust, no need breaking things.

@daveisfera
Copy link

For what my two cents is worth, I'd prefer a version 11 over 10.4 with such big changes

@vitaly-t
Copy link
Owner Author

@daveisfera It might happen, once the underlying driver settles. For now, it is still undergoing those changes, and those are all available through the beta releases.

@vitaly-t
Copy link
Owner Author

On second thought, the major breaking changes are coming in v8.0.0 of the driver, so maybe it will be ok to go with 10.4.0 update here, and then with v11.0.0, using v8.0.0 of the driver?...

@daveisfera
Copy link

Sounds good to me

@vitaly-t
Copy link
Owner Author

Release 10.4.0 concludes this work. Should there be any further problems with the new driver, new issues will be open for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants