Skip to content

Commit

Permalink
reverting the driver
Browse files Browse the repository at this point in the history
  • Loading branch information
@vitaly-t
vitaly-t committed Dec 26, 2019
1 parent 2a29c33 commit f96ad32
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions package.json
View file
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "pg-promise",
"version": "10.4.0",
"version": "10.3.2",
"description": "PostgreSQL interface for Node.js",
"main": "lib/index.js",
"typings": "typescript/pg-promise.d.ts",
Expand Down Expand Up @@ -42,7 +42,7 @@
"dependencies": {
"assert-options": "0.6.0",
"manakin": "0.5.2",
"pg": "7.15.1",
"pg": "7.14.0",
"pg-minify": "1.5.1",
"spex": "3.0.0"
},
Expand Down

4 comments on commit f96ad32

@brianc
Copy link

@brianc brianc commented on f96ad32 Dec 27, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey just saw this! Curious what caused you to revert the driver? If you ever have to revert please lemme know w/ an issue on node-postgres as your module uses pg heavily so sometimes you can catch things early!

@vitaly-t
Copy link
Owner Author

@vitaly-t vitaly-t commented on f96ad32 Dec 27, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@brianc I reverted the version between the commits, not between releases. I did it only to take time to revise the changes before updating it. Repackaging into a monorepo usually carries some dependency changes that may need to be updated, like switching from require('pg-query-stream') to require('packages/pg-query-stream'). You would want to make sure not to introduce an ambiguity in referencing inner packages versus external packages. Have you considered this one yet? I also wanted to give you time to get it all finished, then revise it fully, and only then update the dependency. There's no rush :)

Another thing - once merged, you should add NPM-level deprecation warning into the external packages, and archive the repo, however without dumping issues that are still open against those packages.

See, there is a lot to consider ;)

@brianc
Copy link

@brianc brianc commented on f96ad32 Dec 27, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh yeah! So the thing is....I'm converting to a mono-repo but not to a single package. Still gonna all be published individually & installed separately just like they are now - just that I can actually manage all the code in 1 place and with a single commit or PR I can introduce and fix breaking changes between say pg, pg-cursor, and pg-query-stream. Then lerna does all the semver managing magic which is super handy. But I feel you - definitely best to be careful w/ releases and stuff. Didn't mean to snoop just wanted to make sure I wasn't causing you any more headache than I already do! 😄

@vitaly-t
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@brianc Thanks for clarification! I am releasing all your 17.x updates, for now as beta-s. Will revise after you've finished all the updates, before making an official release.

Please sign in to comment.