Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(plugin-vue): regenerate scoped css in build watch, fix #7980 #7989

Merged
merged 3 commits into from
May 18, 2022
Merged

fix(plugin-vue): regenerate scoped css in build watch, fix #7980 #7989

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1c9741a
fix(plugin-vue): regenerate scoped css when build watch
sapphi-red May 2, 2022
a71a14f
fix(plugin-vue): remove duplicated scope query
sapphi-red May 4, 2022
74268ee
fix(plugin-vue): regenerate template when hasScoped and build watch
sapphi-red May 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions packages/plugin-vue/src/main.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -255,7 +255,7 @@ async function genTemplateCode(
? `&src=${descriptor.id}`
: '&src=true'
: ''
const scopedQuery = hasScoped ? `&scoped=true` : ``
const scopedQuery = hasScoped ? `&scoped=${descriptor.id}` : ``
const attrsQuery = attrsToQuery(template.attrs, 'js', true)
const query = `?vue&type=template${srcQuery}${scopedQuery}${attrsQuery}`
const request = JSON.stringify(src + query)
Expand Down Expand Up @@ -342,7 +342,8 @@ async function genStyleCode(
: '&src=true'
: ''
const directQuery = asCustomElement ? `&inline` : ``
const query = `?vue&type=style&index=${i}${srcQuery}${directQuery}`
const scopedQuery = style.scoped ? `&scoped=${descriptor.id}` : ``
const query = `?vue&type=style&index=${i}${srcQuery}${directQuery}${scopedQuery}`
const styleRequest = src + query + attrsQuery
if (style.module) {
if (asCustomElement) {
Expand Down Expand Up @@ -443,7 +444,7 @@ async function linkSrcToDescriptor(

// these are built-in query parameters so should be ignored
// if the user happen to add them as attrs
const ignoreList = ['id', 'index', 'src', 'type', 'lang', 'module']
const ignoreList = ['id', 'index', 'src', 'type', 'lang', 'module', 'scoped']

function attrsToQuery(
attrs: SFCBlock['attrs'],
Expand Down