[go/mysql] use sync.Pool for reusing bufio writers #4188
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danieltahara
suggested changes
Sep 7, 2018
go/mysql/bufio_pool_test.go
Outdated
| "testing" | ||
| ) | ||
|
|
||
| func TestWriter(t *testing.T) { |
There was a problem hiding this comment.
can you add a test where you have multiple writers. give them each an identifying string to write, and make sure that we don't have corrupt or unclean pooling behavior.
danieltahara
reviewed
Sep 7, 2018
Signed-off-by: Alexander Morozov <lk4d4math@gmail.com>
danieltahara
reviewed
Sep 8, 2018
| writeCount := 10000 | ||
|
|
||
| writeStrings := func(w bufioWriter, testWriter io.Writer) error { | ||
| for i := 0; i < writeCount; i++ { |
There was a problem hiding this comment.
can you add a unique bit to the testString for each writer?
|
Closed by #4190 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I decided to split writers from #4186 because writers easier and not much to discuss about them.
Random queries benchmark after 60s run:
/cc @sougou @danieltahara