Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(runner): improve text.extend types #4176

Merged
merged 4 commits into from
Sep 27, 2023

Conversation

Dunqing
Copy link
Member

@Dunqing Dunqing commented Sep 25, 2023

Description

Partial close - #3915.

Mainly changes

  1. Better any type supports
  2. Add the InferFixturesTypes helper type, which can get fixtures type from TestApi
  3. Some improvement

InferFixturesTypes

interface TypesContext {
  number: number
  array: number[]
  string: string
  any: any
  boolean: boolean
}

const myTest = test.extend<TypesContext>({
  number: 1,
  array: [1, 2, 3],
  async string({ }, use) {
    await use('string')
  },
  async any({}, use) {
    await use({})
  },
  boolean: true,
})

// The type is equal
TypesContext === InferFixturesTypes<typeof typesTest>>

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

@stackblitz
Copy link

stackblitz bot commented Sep 25, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@netlify
Copy link

netlify bot commented Sep 25, 2023

Deploy Preview for fastidious-cascaron-4ded94 canceled.

Name Link
🔨 Latest commit 9fad8c1
🔍 Latest deploy log https://app.netlify.com/sites/fastidious-cascaron-4ded94/deploys/65141af44ef54f0008aaa2aa

@Dunqing Dunqing changed the title feat(runner): improve text.extends types feat(runner): improve text.extend types Sep 25, 2023
@sheremet-va
Copy link
Member

Can you fix the conflicts please?

@sheremet-va sheremet-va merged commit bbb43fb into vitest-dev:main Sep 27, 2023
15 of 17 checks passed
LorenzoBloedow pushed a commit to LorenzoBloedow/vitest that referenced this pull request Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants