-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: run tests sequentially #5677
ci: run tests sequentially #5677
Conversation
✅ Deploy Preview for fastidious-cascaron-4ded94 canceled.
|
|
Yes, these failings are why I opened that PR. No idea why it's failing yet. |
Do you think it might be because we have 3 different pools that have their own min/max worker count? |
Oh right, those pools are run in parallel. The failing linux CIs have 2 CPUs so each pool is using just one worker. But still there's main thread + 3 pool threads/processes running. |
Actually I can reproduce this issue locally with Node Screen.Recording.2024-05-06.at.20.20.17.mov |
Isolated the crashing test to import { test } from 'vitest'
import { hoistMocks } from '../../../packages/vitest/src/node/hoistMocks'
test.only('Helloo', () => {
console.log(hoistMocks)
}) |
Interesting. The only thing I can think of is that it imports parseAst which relies on a native swc module 🤔 |
Oh, it doesn't actually import it, the plugin provides it 🤔 |
Looks like importing |
Almost always fails during import of
🔍
|
Looks like it always fails here:
No error, just exit with 129 code - interestingly, it kills even the main thread |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you try if v22.0.0
works on CI? Locally it doesn't crash like v22.1.0
does. This could help to pinpoint the root cause. 👀
vitest/.github/workflows/ci.yml
Line 42 in bcccce6
node_version: [18, 20, 22] |
- node_version: [18, 20, 22]
+ node_version: [18, 20, 22.0.0]
Actually, I am not even sure why we test against Node 22, it's not LTS yet. We usually wait for it to be LTS or close to it before we add it to CI because it's prone to bugs like this, |
Sure, we could drop it until its LTS plans have been announced and add it back some weeks/months before that. |
1fc50a1
to
9de0cc2
Compare
Description
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
pnpm-lock.yaml
unless you introduce a new test example.Tests
pnpm test:ci
.Documentation
pnpm run docs
command.Changesets
feat:
,fix:
,perf:
,docs:
, orchore:
.