Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): test files notified only when running #6069

Merged
merged 1 commit into from
Jul 10, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions packages/ui/client/composables/client/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ import { parseError } from '../error'
import { activeFileId } from '../params'
import { createStaticClient } from './static'
import { testRunState, unhandledErrors } from './state'
import { uiFiles } from '~/composables/explorer/state'
import { explorerTree } from '~/composables/explorer'
import { isFileNode } from '~/composables/explorer/utils'

Expand Down Expand Up @@ -51,8 +50,7 @@ export const status = ref<WebSocketStatus>('CONNECTING')

export const current = computed(() => {
const currentFileId = activeFileId.value
const entry = uiFiles.value.find(file => file.id === currentFileId)!
return entry ? findById(entry.id) : undefined
return currentFileId ? findById(currentFileId) : undefined
})
export const currentLogs = computed(() => getTasks(current.value).map(i => i?.logs || []).flat() || [])

Expand Down
32 changes: 30 additions & 2 deletions packages/ui/client/composables/explorer/collector.ts
Original file line number Diff line number Diff line change
Expand Up @@ -122,6 +122,16 @@ function updateRunningTodoTests() {
}

function traverseFiles(collect: boolean) {
// add missing files: now we have only files with running tests on the initial ws open event
const files = client.state.getFiles()
const currentFiles = explorerTree.nodes
const missingFiles = files.filter(f => !currentFiles.has(f.id))
for (let i = 0; i < missingFiles.length; i++) {
createOrUpdateFileNode(missingFiles[i], collect)
createOrUpdateEntry(missingFiles[i].tasks)
}

// update pending tasks
const rootTasks = explorerTree.root.tasks
// collect remote children
for (let i = 0; i < rootTasks.length; i++) {
Expand All @@ -142,11 +152,29 @@ function traverseFiles(collect: boolean) {
}

function traverseReceivedFiles(collect: boolean) {
const rootTasks = explorerTree.root.tasks
const updatedFiles = new Map(explorerTree.pendingTasks.entries())
explorerTree.pendingTasks.clear()
const idMap = client.state.idMap

// add missing files: now we have only files with running tests on the initial ws open event
const currentFiles = explorerTree.nodes
const missingFiles = Array
.from(updatedFiles.keys())
.filter(id => !currentFiles.has(id))
.map(id => findById(id))
.filter(Boolean) as File[]

let newFile: File
for (let i = 0; i < missingFiles.length; i++) {
newFile = missingFiles[i]
createOrUpdateFileNode(newFile, false)
createOrUpdateEntry(newFile.tasks)
// remove the file from the updated files
updatedFiles.delete(newFile.id)
}

// collect remote children
const idMap = client.state.idMap
const rootTasks = explorerTree.root.tasks
for (let i = 0; i < rootTasks.length; i++) {
const fileNode = rootTasks[i]
const file = findById(fileNode.id)
Expand Down
3 changes: 2 additions & 1 deletion packages/ui/client/composables/explorer/filter.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import {
isFileNode,
isParentNode,
isTestNode,
sortedRootTasks,
} from '~/composables/explorer/utils'
import { client, findById } from '~/composables/client'
import { filteredFiles, uiEntries } from '~/composables/explorer/state'
Expand Down Expand Up @@ -35,7 +36,7 @@ export function* filterAll(
search: string,
filter: Filter,
) {
for (const node of explorerTree.root.tasks) {
for (const node of sortedRootTasks()) {
yield * filterNode(node, search, filter)
}
}
Expand Down
6 changes: 6 additions & 0 deletions packages/ui/client/composables/explorer/utils.ts
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,12 @@ export function isParentNode(node: UITaskTreeNode): node is FileTreeNode | Suite
return node.type === 'file' || node.type === 'suite'
}

export function sortedRootTasks(tasks = explorerTree.root.tasks) {
return tasks.sort((a, b) => {
return `${a.filepath}:${a.projectName}`.localeCompare(`${b.filepath}:${b.projectName}`)
})
}

export function createOrUpdateFileNode(
file: File,
collect = false,
Expand Down
Loading