Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configuration classes modifications for Dynamic API branch alignment #446

Open
wants to merge 14 commits into
base: main
Choose a base branch
from

Conversation

litvinovg
Copy link
Contributor

@litvinovg litvinovg commented Mar 8, 2024

What does this pull request do?

Ported modifications of configuration related classes from Dynamic API branch.

What's new?

Support for new data property types: boolean, integer.
asString Property annotation parameter
Circularity implementation and test
Added tests to check:
Loading boolean data property
Loading integer data property
Loading Resource URI as String

How should this be tested?

Running standard unit test should be enough.

Interested parties

@VIVO-project/vivo-committers

litvinovg and others added 11 commits March 8, 2024 10:04
    Proof of concept for dynapi february sprint (vivo-project#253)

    * Dynamic API RPC starting point

    * Use String to store dateTime until a better type defined

    * instantinate objects independently in configuration bean loader

    * Modified ontology files

    * Replace requireXXX with requresXXX in dynamic API ontology

    * Parse boolean type while loading instances with ConfigurationBeanLoader

    * Ontology modifications, refactoring.

    * Added n3 template rdf class

    * Renamed rpc name set method

    * Implemented basic support of sparql queries

    * Current state for discussion

    * Multiple fixes, added n3 action example

    * Added typed parameter example, fixed localization tags

    * Defined rdf class RPC to represent RPC call, defined class to represent REST Resources

    * Initialize pools with StartupManager

    * Added draft of REST Endpoint

    * Added default http method to define a method should be used for rpc execution and also REST custom action

    * fix: a mistake, Action should have firstStep, next should be an option of OperationalStep

    * fix: REST custom action names shouldn't be equal to RPC names
    Co-authored-by: William Welling <8352733+wwelling@users.noreply.github.com>
    Co-authored-by: Kevin Day <kday@library.tamu.edu>
    Co-authored-by: Dragan Ivanovic <chenejac@uns.ac.rs>
    Co-authored-by: chenejac <chenejac@gmail.com>

    correct context path vs servlet path

    Refactor Integration Tests to use the full word Test.

    This allows for the tests to be properly picked up and executed.

    Merge pull request vivo-project#281 from kaladay/dynapi-rpc_endpoint_it_to_itest

    [3678] Refactor Integration Tests to use the full word Test.
    Merge branch 'sprint-dynapi-2022-feb-staging' of github.com:vivo-project/Vitro into servlet-path

    Merge pull request vivo-project#280 from wwelling/servlet-path

    Correct context path vs servlet path
    Update of the ontology. Introducing structured parameter types (object and array)

    rest endpoint corrections and integration tests

    Updating binding of the ontology to Java classes and n3 test examples.To be in accordance with changes in the ontology.

    Adding files for primitive types and APIInformation java bean.

    Adding new line at the end of file and retrieving history of deleted files by using git mv

    Adding new line at the end of file

    Merge pull request vivo-project#283 from chenejac/3653_definition_of_the_ontology

    3653 definition of the ontology
    Merge branch 'sprint-dynapi-2022-feb-staging' of github.com:vivo-project/Vitro into 3667-rest-it
    use dynapi model instead of full union

    moved dynamic-api-implementation.n3 to dynapi model
    AbstractPool improvements

    fix configuration bean loader log errors
refact: extracted variables to simplify debugging
    endpoint reorganization in progress

    tests are passing

    test fixes, refactorings, fixed concurrent use of action in DynamicAPIDocumentation

    fix model provider

    removed unused imports

    removed debug statements

    remamings
@litvinovg litvinovg marked this pull request as ready for review March 8, 2024 11:47
@litvinovg litvinovg requested a review from chenejac March 12, 2024 16:45
@litvinovg litvinovg force-pushed the configuration-bean-loader-ported-modifications branch from 7c2443c to b776311 Compare March 12, 2024 16:50
Copy link
Contributor

@chenejac chenejac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unit tests are passing.
The code is clear.
However, it includes dynapi ontology elements, therefore I suggest to discuss this once again within committers group

@chenejac chenejac requested a review from brianjlowe May 2, 2024 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants