Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for VIVO-3957 #452

Merged
merged 1 commit into from
May 2, 2024
Merged

Fix for VIVO-3957 #452

merged 1 commit into from
May 2, 2024

Conversation

litvinovg
Copy link
Contributor

@litvinovg litvinovg commented Mar 19, 2024 •
edited
Loading

VIVO GitHub issue

  • Other Relevant Links (Mailing list discussion, related pull requests, etc.)

What does this pull request do?

Added set of workarounds to fix the issue of updating data in configuration graphs with custom entry forms.

What's new?

  • Return Configuration RDF service in IdModelSelector for models with names DISPLAY, DISPLAY_TBOX and DISPLAY_DISPLAY. That's the only configuration models that are used by VitroModelSource.
  • Return correct model uri by name in getDefaultGraphUri
  • For memory-cached models (all configuration models) wrap model with RDFServiceModel to update in-memory model.

How should this be tested?

A description of what steps someone could take to:

  • Reproduce the problem in the issue
  • Test that the pull request resolves the issue
  • Try to create a person, set email, change label, set position using entry forms.

Interested parties

@VIVO-project/vivo-committers

@litvinovg litvinovg linked an issue Mar 19, 2024 that may be closed by this pull request
Menu pages can't be modified vivo-project/VIVO#3957
Closed
chenejac
chenejac requested changes Apr 2, 2024
View reviewed changes
Copy link
Contributor

@chenejac chenejac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@litvinovg thanks for the PR.

It is fixing the issue.

I have posted one comment regarding the code.

...main/java/edu/cornell/mannlib/vitro/webapp/edit/n3editing/configuration/IdModelSelector.java Outdated Show resolved Hide resolved
@litvinovg litvinovg requested a review from chenejac April 4, 2024 12:06
@litvinovg litvinovg mentioned this pull request Apr 4, 2024
Open
chenejac
chenejac approved these changes Apr 5, 2024
View reviewed changes
Copy link
Contributor

@chenejac chenejac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@litvinovg thanks. Works well, looks well.

@gneissone gneissone self-requested a review April 18, 2024 22:35
gneissone
gneissone approved these changes Apr 18, 2024
View reviewed changes
Copy link
Member

@gneissone gneissone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and the changes resolve the issue.

@chenejac chenejac merged commit d910dd3 into vivo-project:main May 2, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chenejac chenejac chenejac approved these changes

@gneissone gneissone gneissone approved these changes

@brianjlowe brianjlowe Awaiting requested review from brianjlowe

Assignees
No one assigned
Labels
bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Menu pages can't be modified
3 participants
@litvinovg @chenejac @gneissone