Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename and Trash Icons stay after hover #505

Closed
chinm4 opened this issue Feb 5, 2024 · 6 comments
Closed

Rename and Trash Icons stay after hover #505

chinm4 opened this issue Feb 5, 2024 · 6 comments
Assignees

Comments

@chinm4
Copy link
Contributor

chinm4 commented Feb 5, 2024

When navigating up on the sidebar over the Rename and Trash icons the icons are staying there permanently until hovered again
afterhoveringuponeachfilesicons

@curran
Copy link
Contributor

curran commented Feb 5, 2024

Nice catch!

image

I can reproduce it. It has to do with the tooltips I think.

@curran
Copy link
Contributor

curran commented Feb 5, 2024

If we change the hover display for those buttons to be done with CSS rather than JS, I think that would solve this issue.

Otherwise, we may need to listen for more types of mouse events. Maybe it's not getting the mouse out, or there may be some issue with event bubbling out of the tooltip.

@curran
Copy link
Contributor

curran commented Feb 6, 2024

Possibly related to these new changes

#493

@chinm4 chinm4 self-assigned this Feb 9, 2024
@brandonbalchand brandonbalchand self-assigned this Feb 9, 2024
@curran
Copy link
Contributor

curran commented Feb 16, 2024

Another idea on this: the problem seems to be caused by mouse events on the tooltip. What if we just disable all pointer events for the tooltip? That could be an easy fix.

@curran
Copy link
Contributor

curran commented Feb 27, 2024

Here's an idea for a fix: move the state of the hovered item up one level in the component tree.

Or maybe we could just use CSS to show/hide the icons when you hover on the parent.

@curran
Copy link
Contributor

curran commented Mar 26, 2024

Finally fixed in #617 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

3 participants