You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Following https://github.com/vizhub-core/vzcode/pull/575/files, I think it would make sense to treat the entire sidebar as the drop zone, rather than have a specific drop zone called out in the UI. I think that would be cleaner in terms of UI, and also that's what other editors like VSCode do.
The drop zone callout in the UI is good in a way, because it makes the feature discoverable, but my preference would be to keep the UI clean, and use the entire sidebar as the drop zone. It should be possible to do this by migrating DragAndDrop from a React component to a custom hook, maybe called useDragAndDrop, which would return the things used here:
Following https://github.com/vizhub-core/vzcode/pull/575/files, I think it would make sense to treat the entire sidebar as the drop zone, rather than have a specific drop zone called out in the UI. I think that would be cleaner in terms of UI, and also that's what other editors like VSCode do.
The drop zone callout in the UI is good in a way, because it makes the feature discoverable, but my preference would be to keep the UI clean, and use the entire sidebar as the drop zone. It should be possible to do this by migrating
DragAndDrop
from a React component to a custom hook, maybe calleduseDragAndDrop
, which would return the things used here:then those props could be applied to the sidebar itself. I do like the
dragover
style - that could apply to the entire sidebar.The text was updated successfully, but these errors were encountered: