Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drag and drop v1 #575

Merged
merged 3 commits into from
Mar 11, 2024
Merged

drag and drop v1 #575

merged 3 commits into from
Mar 11, 2024

Conversation

CJary
Copy link
Collaborator

@CJary CJary commented Mar 9, 2024

Implemented a new function called createFileWithContent in the useFileCRUD.ts and added it into the VZCodeContext.tsx for the DragAndDrop.jsx.

DragAndDrop.jsx is the component for a file being dragged over and created along with the content inside.

The frontend menu for the DragAndDrop is done by the VZSideBar's styles.scss.

Copy link
Contributor

@curran curran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent! Thank you so much! This works perfectly. I added a commit to clean up a few minor things.

As a follow-up to this one, I think it would make sense to treat the entire sidebar as the drop zone, rather than have a specific drop zone called out in the UI. I think that would be cleaner in terms of UI, and also that's what other editors like VSCode do. I've created a new issue for that here: #577

@curran curran merged commit 65f7d5f into main Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants