Search Feature #754
Merged
Search Feature #754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
curran
approved these changes
Jul 4, 2024
There was a problem hiding this comment.
Absolutely incredible work! This is next level amazing. Thank you so so much!
Some ideas for future improvements:
- Auto-focus the input field after clicking search
- Introduce a keyboard shortcut to trigger search
- Make the search results navigable with the keyboard
- Use the new icons in the sidebar file listings, not just in search results
| // Only conduct a search after fully mounting and entering a new non-empty pattern | ||
| setIsSearching(pattern.trim().length >= 1); | ||
|
|
||
| // Search about 2 seconds after entering a new pattern |
There was a problem hiding this comment.
I feel like this could be set to a shorter time, maybe .5 seconds.
| gap: 8px; | ||
| padding: 8px; | ||
|
|
||
| * { |
| justify-content: space-between; | ||
| align-items: center; | ||
|
|
||
| * { |
There was a problem hiding this comment.
Yeah somehow this pattern of * does not feel good.
| @@ -73,6 +79,22 @@ export type VZAction = | |||
| | { type: 'set_is_settings_open'; value: boolean } | |||
| | { type: 'set_is_doc_open'; value: boolean } | |||
|
|
|||
| // `set_is_search_open` | |||
| // * Sets whether the search tab is open. | |||
| | { type: 'set_is_search_open'; value: boolean } | |||
| const matches = []; | ||
|
|
||
| for (let j = 0; j < lines.length; j++) { | ||
| const index = lines[j].indexOf(pattern);; |
There was a problem hiding this comment.
Very nice implementation for search! I'm curious how fast this is, as it's a brute force algorithm. It's probably fine, but I'd be curious to make unit tests for this function and see how fast it is for various sizes of file trees.
This was referenced Jul 4, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following implements a trivial search feature into the VZCode codebase. Various icons have been added based on the supported Code Mirror file extensions, and any unsupported file extensions that appear in any search will pivot to a default file icon. The search feature required the entire sidebar UI to be updated as shown below.
After a successful non-empty search, users can toggle the visibility of a given search file containing the line matches to be entirely visible, folded, or removed from the view. When clicking any line for the given matched file, the file becomes active, and the exact pattern is highlighted within the code editor.
There are still plenty of opportunities to improve the current implementation, such as adding visuals to toggle matching exact cases, support for regular expressions, etc.