Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-follow: open file feature #781

Merged
merged 5 commits into from
Jul 10, 2024
Merged

Conversation

curran
Copy link
Contributor

@curran curran commented Jul 9, 2024

No description provided.

@DaCatDude
Copy link
Collaborator

openTab isnt being recognized as a function, I followed the imports you suggested here. I think its something really obvious I am missing, but I am not sure what it is. Feels rly close.

@curran
Copy link
Contributor Author

curran commented Jul 10, 2024

@DaCatDude There's just one last step required here - pass it into getOrCreateEditor. If you search the codebase for getOrCreateEditor and see where it is being invoked, add it to that list of options and make sure it's in scope.

@curran
Copy link
Contributor Author

curran commented Jul 10, 2024

I'll pick this up.

@curran curran self-assigned this Jul 10, 2024
@curran
Copy link
Contributor Author

curran commented Jul 10, 2024

Got it! Now there's another issue with scrollToCursor... almost there!

image

@curran
Copy link
Contributor Author

curran commented Jul 10, 2024

Got it totally working woohoo!

@curran curran marked this pull request as ready for review July 10, 2024 16:22
@curran curran merged commit 65e01ad into main Jul 10, 2024
@curran curran changed the title Starting changes for auto-follow open file feature Auto-follow: open file feature Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants