WIP Split Pane #798
Merged
WIP Split Pane #798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
|
Excellent start! Please re-build based on #802 That provides a foundation where you can make the icon clicking do something - probably dispatch a new action that transforms the |
|
Actually, I could merge this if we revert the changes commenting out the DOM removal AND put the new icon behind a feature flag. Ideally the icon could represent a split pane. The "+" symbol may not be the best. |
|
VScode icon for split view: |
|
|
Added my commit. Back to you! |
moved the split view icon to the top right of the editor and add moved the tooltip labels for the run code button and split view icon to display below the icons.
the new split pane reducer takes a leaf pane and converts it into a split pane with two leaf pane childern with the same tabs as the original leaf pane before the split.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
just a draft.
I added a button and a hacky split pane view