Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Context menu #801

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Context menu #801

wants to merge 2 commits into from

Conversation

philippark
Copy link
Collaborator

No description provided.

@philippark
Copy link
Collaborator Author

philippark commented Jul 19, 2024 •
edited
Loading

yet to do:

  • actual interactive buttons on the context menu
  • halt everything on the screen until menu is unclicked.
  • convert js to tsx

curran
curran requested changes Jul 19, 2024
View reviewed changes
Copy link
Contributor

@curran curran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use regular CSS/SaSS. Thanks!

package.json
@@ -148,6 +148,7 @@
"react-router-dom": "^6.24.1",
"sharedb": "^5.0.2",
"sharedb-client-browser": "^5.0.2",
"styled-components": "^6.1.12",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's not adopt styled-components please. We are already all set up with Sass.

@philippark philippark self-assigned this Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@curran curran curran requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@philippark philippark

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@philippark @curran