Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

split pane changes #829

Closed
wants to merge 2 commits into from
Closed

split pane changes #829

wants to merge 2 commits into from

Conversation

michaelhelper
Copy link
Collaborator

No description provided.

@michaelhelper michaelhelper linked an issue Aug 9, 2024 that may be closed by this pull request
@michaelhelper michaelhelper marked this pull request as draft August 9, 2024 18:42
@curran
Copy link
Contributor

curran commented Aug 9, 2024

Closing in favor of #831

Some good ideas here! Specifically

for (const child of activePane.children) {

We'll need this sort of logic in the new SplitPaneView component! More like activePane.children.map(child => <SplitPaneView/>) or something - a recursive React component, which is super cool.

Also the

 // TODO Copy the tab list from the active pane

is totally valid and still needs to be done. Cheers!

@curran curran closed this Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Split Pane View
2 participants