task_1_5_1 #18
Merged
task_1_5_1 #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
|
|
galinabykova
requested changes
Dec 6, 2023
AntonTsoy
suggested changes
Dec 8, 2023
| * @param elem parsed token. | ||
| * @return true if this is an operator. | ||
| */ | ||
| private static boolean isOperator(String elem) { |
There was a problem hiding this comment.
По правилам хорошего тона в классах приватные методы объявляются раньше публичных
There was a problem hiding this comment.
Ээээээааааааыыыыыыээээъъъъъъъъъййййййй
| * @param in input string of expression. | ||
| * @return result of expression if possible. | ||
| */ | ||
| public static double calculate(String in) { |
There was a problem hiding this comment.
Переменной входной строки можно дать более осмысленное и полное имя. Её можно спутать с System.in
There was a problem hiding this comment.
Никнейм можно сделать на гихабе более осмысленным, а не просто фамилия имя
AntonTsoy
approved these changes
Dec 12, 2023
|
|
galinabykova
requested changes
Dec 13, 2023
task_1_5_1/app/src/main/java/task/operations/OprationFactory.java
Outdated
Show resolved
Hide resolved
task_1_5_1/app/src/main/java/task/operations/OprationFactory.java
Outdated
Show resolved
Hide resolved
|
|
|
|
galinabykova
approved these changes
Dec 13, 2023
AntonTsoy
suggested changes
Dec 14, 2023
| @@ -0,0 +1,57 @@ | |||
|
|
|||
| package task; | |||
There was a problem hiding this comment.
Дай более осмысленное имя пакету. У тебя у всех лаб одни те же названия пакетов, хотя задачи ты делаешь на разные темы
| @@ -0,0 +1,38 @@ | |||
| package task.factory; | |||
There was a problem hiding this comment.
Почему ты решил перенести фабрику в отдельный пакет?
| public final class Pow implements Operation { | ||
| @Override | ||
| public double apply(Stack<Double> stack) { | ||
| double op1; |
| class CalculatorTest { | ||
| @Test | ||
| void calculateTest() { | ||
| assertEquals(0, Calculator.calculate("- sqrt 32 pow * 8 4 0.5")); |
There was a problem hiding this comment.
По условию задачи пользователь должен вводить выражения в префиксном виде. Твой калькулятор обработал выражение, котором знаки перемешаны с числами, без исключений. Это недопустимо!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.