Implement combat reach based pathing for chase and charge #2386

balakethelock · 2023-12-28T15:24:37Z

🍰 Pullrequest

Changed the way chase and charge find the end point from bounding radius to combat reach.
Current vmangos behavior: https://www.youtube.com/watch?v=ynGYsxdajfo

Also fixed rooted mob target selecting targets that are slightly outside melee range
https://github.com/vmangos/core/assets/111737968/c9d8188f-2328-43ed-994b-b9ce547329ca

Proof

mobs path much closer to the edge of the hitbox (combat hitbox determinedby combatreach) than currently in vmangos
https://www.youtube.com/watch?v=bh9ecsBsYqc&t=318s
https://www.youtube.com/watch?v=9TPz_mAyYWY&t=36s
mobs can make very small readjustements if the target moves out of their autoattack range, not necessarily walking all the way up to the target's bounding radius
https://www.youtube.com/watch?v=eqkZuxdngbI&t=489
charge takes the unit charging much closer to the edge of the hitbox than currently in vmangos (takes the unit all the way inside the other unit based on bounding radius)
https://youtu.be/jNngovFMofQ?si=eFcR9Xz8BGziIDTL&t=1184

Issues

None

How2Test

https://www.youtube.com/watch?v=Zx9l4yH2u-A

Todo / Checklist

What to do to a charge started by a unit that is already within melee range of its victim. Needs classic examples of a mob charging a player inside melee.

ratkosrb · 2023-12-28T15:42:23Z

src/game/Objects/Player.cpp

@@ -15696,8 +15696,8 @@ bool Player::IsAllowedToLoot(Creature const* creature)

 float Player::GetMaxLootDistance(Unit const* pUnit) const
 {
-    float distance = GetCombatReach() + 1.333333373069763f + pUnit->GetCombatReach();


But this function is based on the client, it uses this constant and adds the combat reach of both. Why is the constant not used in your new code? Are you making the loot distance be different server side than it is client side?

This the client's check whether target is in loot distance, decompiled by IDA.

double v2; // st7 float v4; // [esp+8h] [ebp+8h] v2 = *(float *)&this->UnitBase.UnitData->unitFields.UNIT_FIELD_COMBATREACH + 1.333333373069763 + *(float *)&a2->UnitData->unitFields.UNIT_FIELD_COMBATREACH; if ( v2 >= 5.0 ) v4 = v2; else v4 = 5.0; return v4;

The same function used by the client for loot distance is used for melee spells:
highest of the two: (Player combat reach + the melee reach constant + target combat reach) or ( 5 yards)

https://github.com/vmangos/core/blob/50f014e1ef9fb36c5ce0df8f1d8dd9c276ef5619/src/game/Objects/Unit.cpp#L10310C35-L10310C35

I made it call to that function to signify to people looking at the code in the future that the two ranges are the same and determined by client.

I should change BASE_MELEERANGE_OFFSET from 1.33f to the full value extracted from the client.

ratkosrb · 2023-12-28T15:44:37Z

src/game/Maps/PathFinder.cpp

        {
            Vector3 dirVect;
            pTarget->GetPosition(dirVect.x, dirVect.y, dirVect.z);
            dirVect -= m_pathPoints[i - 1];
-            float targetDist = pTarget->GetDistance(m_pathPoints[i - 1].x, m_pathPoints[i - 1].y, m_pathPoints[i - 1].z) - meleeReach;
+            float targetDist = pTarget->GetDistance(m_pathPoints[i - 1].x, m_pathPoints[i - 1].y, m_pathPoints[i - 1].z, SizeFactor::None);
+            targetDist -= meleeReach;


Shouldn't you have some guards against targetDist becoming negative?

It can be negative only if m_pathPoints[0] (the start pos of the movement) is inside the target's meleeReach. Normally the CanReachWithMeleeAutoAttack check that happens before should catch that and return to make the unit charge in place.

Untitled.video.-.Made.with.Clipchamp.3.mp4

2023-12-28.19-27-02.mp4

I tested removing the CanReachWithMeleeAutoAttack check and charging from inside melee range and this is what happens:

2023-12-28.18-26-12.mp4

2023-12-28.18-28-49.mp4

Nevertheless I suppose it's safer to check a second time and interrupt the charge to make double sure the charger doesn't path away from the target?

Though I'm curious to know what exactly do mobs in classic do when they charge a unit that is already in their melee range. All the examples I built this on is charging from a distance. In the case of players all charges have a 8 yard minimum range so it's impossible to make an analogy to mobs.

ratkosrb · 2023-12-28T18:39:47Z

src/game/Threat/ThreatManager.cpp

+                float attackDistance = pAttacker->GetMaxChaseDistance(target);
+                // second choice targets are: immune to attacker's autoattack damage school / is secondary threat target (fear, gouge etc) /
+                // is outside of attacker's caster chase distance if rooted caster / is unreachable by attacker's melee attacks if rooted melee.
+                if ( target->IsImmuneToDamage(pAttacker->GetMeleeDamageSchoolMask()) || (target->IsSecondaryThreatTarget()) ||


why is (target->IsSecondaryThreatTarget()) wrapped in brackets, its just 1 function call, doesn't need brackets

Brackets brack off

to exact value found by decompiling the client

ratkosrb · 2023-12-29T11:23:59Z

src/game/Objects/Unit.cpp

@@ -10202,7 +10202,7 @@ bool Unit::GetRandomAttackPoint(Unit const* attacker, float &x, float &y, float
    float angle = GetAngle(attacker);
    float sizeFactor = GetObjectBoundingRadius() + attacker->GetObjectBoundingRadius();


Did you forget to change this to Combat Reach or is it supposed to be Bounding Radius?

The spreading (along with the backpedal) behavior is to be done later. I have videos that show it's current behavior is wrong, but not enough to make a new method of doing it.

Right now the mobs come at the player from a random angle that grows with the number of attackers. This video from classic shows the initial attack point is simply the closest point and not at a random angle, it's only AFTER they reach the player that they start spreading out.

It is meant to be bounding radius at the moment (that's supposedly the hitbox used for collisions) but it will likely get removed entirely later if we get info on how mobs spread (what i need the most is examples of mobs with big bounding radius, like pulling a big number of the Withered Protector mob and recording how they spread around the player)

@balakethelock Can you reply please so we can merge this? Is this an oversight or is it intended?

Oops it was pending this whole time :')
sorry

…angos#2386)" This reverts commit fa09f08.

Gamemechanicwow · 2024-03-29T18:25:46Z

This PR seems to cause issues with targetted creature movement - if the player is running straight towards the creature.

Video-Fri-Mar-29-2024-19-13-32.webm

ratkosrb · 2024-03-29T18:30:47Z

Let's wait for @balakethelock to respond. If he can't fix it then we can revert the commit.

balakethelock · 2024-03-29T21:35:46Z

#2565

balakethelock added 3 commits December 28, 2023 12:21

Changes to charge and chase movement

18dc735

Chase & Charge movement part2

a1e9aba

Typo

50f014e

balakethelock mentioned this pull request Dec 28, 2023

Remove hack to Onyxia's combatreach & boundingrad #2387

Merged

1 task

ratkosrb reviewed Dec 28, 2023

View reviewed changes

balakethelock added 2 commits December 28, 2023 19:49

Removing unnecessary brackets

f35b89b

Brackets brack off

Update BASE_MELEERANGE_OFFSET

fe1550f

to exact value found by decompiling the client

ratkosrb reviewed Dec 29, 2023

View reviewed changes

ratkosrb merged commit fa09f08 into vmangos:development Mar 4, 2024
3 checks passed

Gamemechanicwow added a commit to Gamemechanicwow/core that referenced this pull request Mar 29, 2024

Revert "Implement combat reach based pathing for chase and charge (vm…

0e0e109

…angos#2386)" This reverts commit fa09f08.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement combat reach based pathing for chase and charge #2386

Implement combat reach based pathing for chase and charge #2386

balakethelock commented Dec 28, 2023 •

edited

Loading

ratkosrb Dec 28, 2023 •

edited

Loading

balakethelock Dec 28, 2023

ratkosrb Dec 28, 2023 •

edited

Loading

balakethelock Dec 28, 2023

ratkosrb Dec 28, 2023

ratkosrb Dec 29, 2023

balakethelock Dec 29, 2023

ratkosrb Jan 5, 2024

balakethelock Jan 5, 2024 •

edited

Loading

Gamemechanicwow commented Mar 29, 2024

ratkosrb commented Mar 29, 2024

balakethelock commented Mar 29, 2024

		@@ -10202,7 +10202,7 @@ bool Unit::GetRandomAttackPoint(Unit const* attacker, float &x, float &y, float
		float angle = GetAngle(attacker);
		float sizeFactor = GetObjectBoundingRadius() + attacker->GetObjectBoundingRadius();

Implement combat reach based pathing for chase and charge #2386

Implement combat reach based pathing for chase and charge #2386

Conversation

balakethelock commented Dec 28, 2023 • edited Loading

🍰 Pullrequest

Proof

Issues

How2Test

Todo / Checklist

ratkosrb Dec 28, 2023 • edited Loading

Choose a reason for hiding this comment

balakethelock Dec 28, 2023

Choose a reason for hiding this comment

ratkosrb Dec 28, 2023 • edited Loading

Choose a reason for hiding this comment

balakethelock Dec 28, 2023

Choose a reason for hiding this comment

ratkosrb Dec 28, 2023

Choose a reason for hiding this comment

ratkosrb Dec 29, 2023

Choose a reason for hiding this comment

balakethelock Dec 29, 2023

Choose a reason for hiding this comment

ratkosrb Jan 5, 2024

Choose a reason for hiding this comment

balakethelock Jan 5, 2024 • edited Loading

Choose a reason for hiding this comment

Gamemechanicwow commented Mar 29, 2024

ratkosrb commented Mar 29, 2024

balakethelock commented Mar 29, 2024

balakethelock commented Dec 28, 2023 •

edited

Loading

ratkosrb Dec 28, 2023 •

edited

Loading

ratkosrb Dec 28, 2023 •

edited

Loading

balakethelock Jan 5, 2024 •

edited

Loading