Add mangosd parameter "DurabilityLoss.Enable" #2712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also remove the following unused parameters: DurabilityLossChance.Absorb DurabilityLossChance.Parry DurabilityLossChance.Block
|
Those parameters should not be removed, as they are useful for tuning a server and testing |
|
The parameters are not implemented, they are only in the config, not in the source code. |
|
Removing the parameters was obviously forgotten in commit 41e3757 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🍰 Pullrequest
Add mangosd parameter "DurabilityLoss.Enable" which allows to disable durability loss completely. Also remove the following unused parameters:
DurabilityLossChance.Absorb
DurabilityLossChance.Parry
DurabilityLossChance.Block
Proof
Issues
How2Test
Switch on and off, then get hit by creatures or die.
Todo / Checklist