optimize

Signed-off-by: Vacant2333 <vacant2333@gmail.com>

cmd/webhook-manager/app/server.go

@@ -17,6 +17,7 @@ limitations under the License.
 package app
 
 import (
+	"errors"
 	"fmt"
 	"net/http"
 	"os"
@@ -46,10 +47,6 @@ func Run(config *options.Config) error {
 		}
 	}
 
-	if config.WebhookURL == "" && config.WebhookNamespace == "" && config.WebhookName == "" {
-		return fmt.Errorf("failed to start webhooks as both 'url' and 'namespace/name' of webhook are empty")
-	}
-
 	restConfig, err := kube.BuildConfig(config.KubeClientOptions)
 	if err != nil {
 		return fmt.Errorf("unable to build k8s config: %v", err)
@@ -101,7 +98,7 @@ func Run(config *options.Config) error {
 	}
 	go func() {
 		err = server.ListenAndServeTLS("", "")
-		if err != nil && err != http.ErrServerClosed {
+		if err != nil && !errors.Is(err, http.ErrServerClosed) {
 			klog.Fatalf("ListenAndServeTLS for admission webhook failed: %v", err)
 			close(webhookServeError)
 		}

pkg/webhooks/router/admission.go

@@ -58,6 +58,8 @@ func ForEachAdmission(config *options.Config, handler func(*AdmissionService) er
 			if err := handler(service); err != nil {
 				return err
 			}
+		} else {
+			return fmt.Errorf("enabled admission %s not found on the admission registered map", admission)
 		}
 	}
 	return nil