Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move admission webhook registeration into source code from yaml #329

Closed
TommyLike opened this issue Jul 11, 2019 · 3 comments
Closed

Move admission webhook registeration into source code from yaml #329

TommyLike opened this issue Jul 11, 2019 · 3 comments

Comments

@TommyLike
Copy link
Contributor

Is this a BUG REPORT or FEATURE REQUEST?:

Uncomment only one, leave it on its own line:

/kind bug

/kind feature

What happened:
Now we have separated yaml file to register admission webhook, we should move it into source code which keeps maintaince easier.

What you expected to happen:

How to reproduce it (as minimally and precisely as possible):

Anything else we need to know?:

Environment:

  • Volcano Version:
  • Kubernetes version (use kubectl version):
  • Cloud provider or hardware configuration:
  • OS (e.g. from /etc/os-release):
  • Kernel (e.g. uname -a):
  • Install tools:
  • Others:
@hzxuzhonghu
Copy link
Collaborator

agree, moves it to /installer

@TommyLike
Copy link
Contributor Author

agree, moves it to /installer

I mean use code to register webhookconfiguration resource when starting admission service.

@hzxuzhonghu
Copy link
Collaborator

IC, SGTM

thandayuthapani pushed a commit to thandayuthapani/volcano that referenced this issue Jul 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants