Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

retain pod with special phase #176

Merged
merged 1 commit into from
May 16, 2019
Merged

retain pod with special phase #176

merged 1 commit into from
May 16, 2019

Conversation

lminzhw
Copy link
Contributor

@lminzhw lminzhw commented May 16, 2019

xref: #129

Now, pod would be delete when calling KillJob function.

I try to retain part of them based of pod phase.

@TommyLike
Copy link
Contributor

@lminzhw Is there a overlap with PR #156

@lminzhw
Copy link
Contributor Author

lminzhw commented May 16, 2019

@lminzhw Is there a overlap with PR #156

No.

#156 change the status of job, but still delete the pod as before. This PR just want to limit the range of pod to be deleted.

@k82cn
Copy link
Member

k82cn commented May 16, 2019

/lgtm
/approve

@volcano-sh-bot volcano-sh-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. labels May 16, 2019
@volcano-sh-bot volcano-sh-bot merged commit b0db21d into volcano-sh:master May 16, 2019
kevin-wangzefeng pushed a commit to kevin-wangzefeng/volcano that referenced this pull request Jun 28, 2019
@volcano-sh-bot
Merge pull request volcano-sh#176 from lminzhw/retain_pod
85e3350 
retain pod with special phase
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lminzhw @TommyLike @k82cn @volcano-sh-bot