Dynamic loading comfigmap about action and plugins of scheduler, move loadSchedulerConf processing from run to runOnce #504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
volcano-sh-bot
added
the
size/M
sivanzcw
changed the title
|
Hey @sivanzcw, TravisBuddy Request Identifier: 32769770-fc8a-11e9-afa1-7d9fdd5cb875 |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: k82cn, sivanzcw The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
volcano-sh-bot
added
the
approved
hzxuzhonghu
reviewed
Nov 14, 2019
| @@ -91,6 +74,8 @@ func (pc *Scheduler) runOnce() { | |||
| defer glog.V(4).Infof("End scheduling ...") | |||
| defer metrics.UpdateE2eDuration(metrics.Duration(scheduleStartTime)) | |||
|
|
|||
| pc.loadSchedulerConf() | |||
There was a problem hiding this comment.
For better performance, we can add a file watcher
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reason for this changes is to realize dynamically loading configuration of scheduler. When configuration about
actionorpluginsof scheduler changes, the scheduler can load and use the new configuration without restarting.For time of loading configuration is very shot, the changes has no effect on the scheduling performance
Time duration of
scheduler.loadSchedulerConffunction504.386