Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add explict info about what todo to update generated yaml #578

Merged
merged 1 commit into from
Dec 3, 2019

Conversation

hzxuzhonghu
Copy link
Collaborator

No description provided.

@volcano-sh-bot volcano-sh-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 2, 2019
@TravisBuddy
Copy link

Hey @hzxuzhonghu,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 847aa1b0-14ef-11ea-a5d4-6b7b0fca08ad

@k82cn
Copy link
Member

k82cn commented Dec 3, 2019

/lgtm
/approve

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 3, 2019
@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hzxuzhonghu, k82cn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 3, 2019
@TravisBuddy
Copy link

Hey @hzxuzhonghu,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: f2e81910-1577-11ea-a5d4-6b7b0fca08ad

@volcano-sh-bot volcano-sh-bot merged commit 66274c2 into volcano-sh:master Dec 3, 2019
@hzxuzhonghu hzxuzhonghu deleted the gen-yaml branch December 3, 2019 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants