Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove scheduling.v1alpha1 and scheduling.v1alpha2 API #693

Merged
merged 4 commits into from
Feb 8, 2020
Merged

Remove scheduling.v1alpha1 and scheduling.v1alpha2 API #693

merged 4 commits into from
Feb 8, 2020

Conversation

thandayuthapani
Copy link
Contributor

Fixes #692

Remove scheduling.v1alpha1 and scheduling.v1alpha2 API

@volcano-sh-bot volcano-sh-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Feb 7, 2020
@TravisBuddy
Copy link

Hey @thandayuthapani,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 2fb51970-49d9-11ea-83a0-77379528e44b

@TravisBuddy
Copy link

Travis tests have failed

Hey @thandayuthapani,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 3ac5ef50-49da-11ea-83a0-77379528e44b

@k82cn
Copy link
Member

k82cn commented Feb 8, 2020

/approve

@volcano-sh-bot volcano-sh-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 8, 2020
@k82cn
Copy link
Member

k82cn commented Feb 8, 2020

LGTM overall, just one tiny comment :)

@k82cn
Copy link
Member

k82cn commented Feb 8, 2020

Thanks very much to you! We need to get it merged until next week to make sure everyone aware this API change.

k82cn
k82cn approved these changes Feb 8, 2020
View reviewed changes
Copy link
Member

@k82cn k82cn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall :)

pkg/apis/scheduling/v1beta1/types.go
@@ -262,6 +262,9 @@ type QueueSpec struct {
Weight int32 `json:"weight,omitempty" protobuf:"bytes,1,opt,name=weight"`
Capability v1.ResourceList `json:"capability,omitempty" protobuf:"bytes,2,opt,name=capability"`

// State controller the status of queue
State QueueState `json:"state,omitempty" protobuf:"bytes,3,opt,name=state"`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's move this State into QueueStatus :) (I think I already did that, that's why we introduce v1beta1)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will make those changes and raise new PR

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 8, 2020
@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: k82cn, thandayuthapani

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot merged commit d5cb25a into volcano-sh:master Feb 8, 2020
@thandayuthapani thandayuthapani mentioned this pull request Feb 8, 2020
Merged
@merryzhou merryzhou mentioned this pull request Mar 1, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@k82cn k82cn k82cn approved these changes

@hex108 hex108 Awaiting requested review from hex108

@hzxuzhonghu hzxuzhonghu Awaiting requested review from hzxuzhonghu

@quinton-hoole quinton-hoole Awaiting requested review from quinton-hoole

Assignees

@k82cn k82cn

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove scheduling.v1alpha1 and scheduling.v1alpha2 API
4 participants
@thandayuthapani @TravisBuddy @k82cn @volcano-sh-bot