Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added env var for scheduler name. #702

Merged
merged 1 commit into from
Feb 16, 2020
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 16 additions & 1 deletion pkg/cli/vsub/run.go
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ package vsub

import (
"fmt"
"os"

"github.com/spf13/cobra"

Expand Down Expand Up @@ -57,7 +58,21 @@ func InitRunFlags(cmd *cobra.Command) {
cmd.Flags().IntVarP(&launchJobFlags.Replicas, "replicas", "r", 1, "the total tasks of job")
cmd.Flags().StringVarP(&launchJobFlags.Requests, "requests", "R", "cpu=1000m,memory=100Mi", "the resource request of the task")
cmd.Flags().StringVarP(&launchJobFlags.Limits, "limits", "L", "cpu=1000m,memory=100Mi", "the resource limit of the task")
cmd.Flags().StringVarP(&launchJobFlags.SchedulerName, "scheduler", "S", "volcano", "the scheduler for this job")
cmd.Flags().StringVarP(&launchJobFlags.SchedulerName, "scheduler", "S", "", "the scheduler for this job, overwrite the value of 'VOLCANO_SCHEDULER_NAME' (default \"volcano\")")

setDefaultArgs()
}

func setDefaultArgs() {
if launchJobFlags.SchedulerName == "" {
schedulerName := os.Getenv("VOLCANO_SCHEDULER_NAME")

if schedulerName != "" {
launchJobFlags.SchedulerName = schedulerName
} else {
launchJobFlags.SchedulerName = "volcano"
}
}
}

var jobName = "job.volcano.sh"
Expand Down