Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added default namespace env for other CLIs - vcancel, vjobs, vresume, vsuspend #729

Closed
wants to merge 1 commit into from

Conversation

thandayuthapani
Copy link
Contributor

xref #700

@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: thandayuthapani
To complete the pull request process, please assign kevin-wangzefeng
You can assign the PR to them by writing /assign @kevin-wangzefeng in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 4, 2020
@k82cn
Copy link
Member

k82cn commented Mar 4, 2020

let's build a util function for that as Namespace is a common parameter for CLIs.

@hzxuzhonghu
Copy link
Collaborator

What happens when we leave it to empty? From my understanding, it works as default. If so, why do we need this?

@thandayuthapani
Copy link
Contributor Author

let's build a util function for that as Namespace is a common parameter for CLIs.

Flag struct variable and struct are not exposed, so creating a util function to handle all those struct will be a problem.

@k82cn
Copy link
Member

k82cn commented Mar 5, 2020

Flag struct variable and struct are not exposed, so creating a util function to handle all those struct will be a problem.

Let's add struct such as JobCommonFlags :)

@stale
Copy link

stale bot commented Aug 18, 2020

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 18, 2020
@stale stale bot closed this Aug 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants