Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix task name default and validate it #76

Merged
merged 2 commits into from
Apr 9, 2019
Merged

Fix task name default and validate it #76

merged 2 commits into from
Apr 9, 2019

Conversation

hzxuzhonghu
Copy link
Collaborator

fixes: #63

@TommyLike
Copy link
Contributor

Can you update the testcase as well?

@hzxuzhonghu
Copy link
Collaborator Author

Sure, will add some cases

@hzxuzhonghu
Copy link
Collaborator Author

Oh, just find that we donot even have a ut.

@k82cn k82cn merged commit e92c859 into master Apr 9, 2019
@k82cn k82cn deleted the task-name branch April 9, 2019 03:40
kevin-wangzefeng pushed a commit to kevin-wangzefeng/volcano that referenced this pull request Apr 30, 2019
Merge pull request volcano-sh#76 from volcano-sh/task-name
84e5064
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

make mutating and validating admission controllers consistent
3 participants
@hzxuzhonghu @TommyLike @k82cn