NPE during status update with Shikimori provider

[tie]

Describe the bug

NPE during status update with Shikimori provider.

Logs

[2024-03-03 22:00:13.766 +03:00] [INF] [149] jellyfin_ani_sync.UpdateProviderStatus: (Tvdb) Anime reference found in anime list XML
[2024-03-03 22:00:13.766 +03:00] [INF] [149] jellyfin_ani_sync.UpdateProviderStatus: Retrieving provider IDs from offline database...
[2024-03-03 22:00:14.466 +03:00] [INF] [208] jellyfin_ani_sync.UpdateProviderStatus: Retrieved provider IDs
[2024-03-03 22:00:14.466 +03:00] [INF] [208] jellyfin_ani_sync.UpdateProviderStatus: Using provider Shikimori...
[2024-03-03 22:00:28.544 +03:00] [ERR] [208] jellyfin_ani_sync.SessionServerEntry: Fatal error occured during anime sync job: System.NullReferenceException: Object reference not set to an instance of an object.
   at jellyfin_ani_sync.UpdateProviderStatus.TitleCheck(Anime anime, Episode episode, Movie movie)
   at jellyfin_ani_sync.UpdateProviderStatus.Update(BaseItem e, Guid userId, Boolean playedToCompletion)
   at jellyfin_ani_sync.SessionServerEntry.PlaybackStopped(Object sender, PlaybackStopEventArgs e)

To Reproduce

n/a

Expected behavior

The plugin successfully updates progress via Shikimori API.

Screenshots

n/a

Desktop (please complete the following information):

• Browser n/a
• Jellyfin version 10.8.13
• Plugin version 3.0

Additional context

I’d assume that is because Anime instance is not fully initialized from the available Shikimori data,

jellyfin-ani-sync/Helpers/ClassConversions.cs

Lines 97 to 102 in de2c883

	public static Anime ConvertShikimoriAnime(ShikimoriMedia shikimoriAnime) =>
	new() {
	Id = shikimoriAnime.Id,
	Title = shikimoriAnime.Name,
	NumEpisodes = shikimoriAnime.Episodes
	};

jellyfin-ani-sync/UpdateProviderStatus.cs

Lines 341 to 347 in de2c883

	private bool TitleCheck(Anime anime, Episode episode, Movie movie) {
	var title = _animeType == typeof(Episode) ? episode.SeriesName : movie.Name;
	return CompareStrings(anime.Title, title) ||
	CompareStrings(anime.AlternativeTitles.En, title) ||
	(anime.AlternativeTitles.Ja != null && CompareStrings(anime.AlternativeTitles.Ja, title)) ||
	(anime.AlternativeTitles.Synonyms != null && anime.AlternativeTitles.Synonyms.Any(synonym => CompareStrings(synonym, title)));
	}

jellyfin-ani-sync/Models/Shikimori/ShikimoriMedia.cs

Lines 7 to 21 in de2c883

	public class ShikimoriMedia {
	[JsonPropertyName("id")]
	public int Id { get; set; }
	[JsonPropertyName("name")]
	public string? Name { get; set; }
	[JsonPropertyName("episodes")]
	public int Episodes { get; set; }
	[JsonPropertyName("episodes_aired")]
	public int EpisodesAired { get; set; }
	[JsonPropertyName("synonyms")] public List<string> RelatedAnime { get; set; } = new();
	[JsonPropertyName("english")]
	public List<string>? English { get; set; }
	[JsonPropertyName("japanese")]
	public List<string>? Japanese { get; set; }
	}

Here is a response from https://shikimori.one/api/animes/52299 with most of the fields omitted except for those that should be used for title check:

{
  "id": 52299,
  "myanimelist_id": 52299,
  "name": "Ore dake Level Up na Ken",
  "russian": "Поднятие уровня в одиночку",
  "english": [ "Solo Leveling" ],
  "japanese": [ "俺 だ け レ ベ ル ア ッ プ な 件 " ],
  "synonyms": [
    "I Level Up Alone",
    "Na Honjaman Level Up"
  ]
}

Also note that strings may be null, e.g. https://shikimori.one/api/animes/54873

{
  "id": 54873,
  "myanimelist_id": 54873,
  "name": "Takoru TV",
  "russian": "Такору",
  "english": [
    null
  ],
  "japanese": [
    "た こ る TV"
  ],
  "synonyms": []
}