-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Shikimori provider issues #111
Conversation
#110 can be fixed more efficiently with Shikimori GraphQL API. I've marked the PR as a draft for now until I implement this. |
I haven’t verified rewatching and adding new titles to the watching list, but otherwise seems to be working fine. Note though that the implementation in this PR currently does not use |
Looks like it’s not necessary.
Thanks for this PR, using GraphQL is pretty much always better in terms of efficiency so these changes are great. Any reason for removing the JSON converter functionality? I think the only reason to keep certain fields like ID as |
I feel like IDs being integers is an implementation detail. There are no operations that actually rely on the fact that IDs are integers, API returns and accepts them as strings, and keeping them as strings throughout the plugin code makes the code a bit more flexible in terms of providers that can be supported (not all APIs use sequential integers for IDs, e.g. it is also common to have UUID strings). |
Okay, fair enough. I can't see any issues with this, I haven't tested it myself as I can't retrieve my Shikimori account but since you have given it a go I think its safe to merge in. Thanks again for the contributions 👍 I am still planning on making some changes so I don't think a new update will be going out any time soon containing these fixes, so if you would like to use these features I would suggest just building your own version. |
Fixes #107, fixes #110