Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes for Jellyfin 10.9 #125

Merged
merged 4 commits into from
May 13, 2024
Merged

Changes for Jellyfin 10.9 #125

merged 4 commits into from
May 13, 2024

Conversation

harshithmohan
Copy link
Contributor

  • Now uses dotnet 8.0, same as Jellyfin 10.9
  • Changed IServerEntryPoint into IHostedService
    • RunAsync changed to StartAsync
    • Dispose changed to StopAsync
    • GC.SuppressFinalize(this); is not needed anymore
    • Added new class PluginServiceRegistrator to register UserDataServerEntry and SessionServerEntry , required for IHostedService to work. It doesn't work automatically like IServerEntryPoint had.
  • MediaTypes now uses MediaType enum instead of string
  • Tested on 10.9.1
  • Fixes Jellyfin 10.9 released #124
  • Not sure if build.yaml is being used but changed it anyway

@vosmiic vosmiic self-requested a review May 13, 2024 16:27
@harshithmohan
Copy link
Contributor Author

I forgot to update the Dockerfile. My bad 🤦

@vosmiic
Copy link
Owner

vosmiic commented May 13, 2024

I forgot to update the Dockerfile. My bad 🤦

No worries, looks like the docker build command was failing too because --output is no longer supported.
There still seems to be an issue with the nuget signatures but I might merge it anyway and fix it at some point over the next few days as this is preventing users from using the plugin if they have updated Jellyfin.

Thank you for creating this PR and getting the plugin up to date for the new Jellyfin version!

@vosmiic vosmiic merged commit 3e84a6c into vosmiic:master May 13, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Jellyfin 10.9 released
2 participants