fix: tests

voxmedia · Mar 2, 2021 · 0476331 · 0476331
1 parent 60248a1
commit 0476331
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 6 deletions.
diff --git a/__tests__/utils.spec.js b/__tests__/utils.spec.js
@@ -33,9 +33,19 @@ describe('Utils', () => {
       it('links to the action workflow', () => {
         const attachments = buildSlackAttachments({ status: 'STARTED', color: 'good', github: GITHUB_PUSH_EVENT });
 
-        expect(attachments[0].fields.find(a => a.title === 'Action')).toEqual({
-          title: 'Action',
-          value: `<https://github.com/voxmedia/github-action-slack-notify-build/commit/abc123/checks | CI>`,
+        expect(attachments[0].fields.find(a => a.title === 'Workflow')).toEqual({
+          title: 'Workflow',
+          value: `<https://github.com/voxmedia/github-action-slack-notify-build/actions/runs/12345 | CI>`,
+          short: true,
+        });
+      });
+
+      it('links to the action job', () => {
+        const attachments = buildSlackAttachments({ status: 'STARTED', color: 'good', github: GITHUB_PUSH_EVENT });
+
+        expect(attachments[0].fields.find(a => a.title === 'Job')).toEqual({
+          title: 'Job',
+          value: `<https://github.com/voxmedia/github-action-slack-notify-build/actions/runs/12345 | build and push>`,
           short: true,
         });
       });
@@ -65,9 +75,9 @@ describe('Utils', () => {
       it('links to the action workflow', () => {
         const attachments = buildSlackAttachments({ status: 'STARTED', color: 'good', github: GITHUB_PR_EVENT });
 
-        expect(attachments[0].fields.find(a => a.title === 'Action')).toEqual({
-          title: 'Action',
-          value: `<https://github.com/voxmedia/github-action-slack-notify-build/commit/xyz678/checks | CI>`,
+        expect(attachments[0].fields.find(a => a.title === 'Workflow')).toEqual({
+          title: 'Workflow',
+          value: `<https://github.com/voxmedia/github-action-slack-notify-build/actions/runs/12345 | CI>`,
           short: true,
         });
       });

diff --git a/fixtures.js b/fixtures.js
@@ -14,6 +14,8 @@ export const GITHUB_PUSH_EVENT = {
     workflow: 'CI',
     eventName: 'push',
     sha: 'abc123',
+    job: 'build and push',
+    runId: 12345,
   },
 };
 
@@ -33,5 +35,7 @@ export const GITHUB_PR_EVENT = {
     workflow: 'CI',
     eventName: 'pull_request',
     sha: 'abc123',
+    job: 'build and push',
+    runId: 12345,
   },
 };