feat: putting repo name more prominently

voxmedia · Mar 3, 2021 · 373da97 · 373da97
1 parent d906713
commit 373da97
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 15 deletions.
diff --git a/__tests__/utils.spec.js b/__tests__/utils.spec.js
@@ -1,7 +1,6 @@
 import { formatChannelName, buildSlackAttachments } from '../src/utils';
 import { GITHUB_PUSH_EVENT, GITHUB_PR_EVENT } from '../fixtures';
 const runId = parseInt(process.env.GITHUB_RUN_ID, 10);
-const job = process.env.GITHUB_JOB;
 
 describe('Utils', () => {
   describe('formatChannelName', () => {
@@ -42,12 +41,12 @@ describe('Utils', () => {
         });
       });
 
-      it('links to the action job', () => {
+      it('links to the action repo', () => {
         const attachments = buildSlackAttachments({ status: 'STARTED', color: 'good', github: GITHUB_PUSH_EVENT });
 
-        expect(attachments[0].fields.find(a => a.title === 'Job')).toEqual({
-          title: 'Job',
-          value: `<https://github.com/voxmedia/github-action-slack-notify-build/actions/runs/${runId} | ${job}>`,
+        expect(attachments[0].fields.find(a => a.title === 'Repo')).toEqual({
+          title: 'Repo',
+          value: `<https://github.com/voxmedia/github-action-slack-notify-build | voxmedia/github-action-slack-notify-build>`,
           short: true,
         });
       });

diff --git a/dist/index.js b/dist/index.js
@@ -11950,7 +11950,6 @@ function buildSlackAttachments({ status, color, github }) {
   const branch = event === 'pull_request' ? payload.pull_request.head.ref : ref.replace('refs/heads/', '');
 
   const sha = event === 'pull_request' ? payload.pull_request.head.sha : github.context.sha;
-  const job = process.env.GITHUB_JOB;
   const runId = parseInt(process.env.GITHUB_RUN_ID, 10);
 
   const referenceLink =
@@ -11971,13 +11970,13 @@ function buildSlackAttachments({ status, color, github }) {
       color,
       fields: [
         {
-          title: 'Workflow',
-          value: `<https://github.com/${owner}/${repo}/actions/runs/${runId} | ${workflow}>`,
+          title: 'Repo',
+          value: `<https://github.com/${owner}/${repo} | ${owner}/${repo}>`,
           short: true,
         },
         {
-          title: 'Job',
-          value: `<https://github.com/${owner}/${repo}/actions/runs/${runId} | ${job}>`,
+          title: 'Workflow',
+          value: `<https://github.com/${owner}/${repo}/actions/runs/${runId} | ${workflow}>`,
           short: true,
         },
         {

diff --git a/src/utils.js b/src/utils.js
@@ -7,7 +7,6 @@ function buildSlackAttachments({ status, color, github }) {
   const branch = event === 'pull_request' ? payload.pull_request.head.ref : ref.replace('refs/heads/', '');
 
   const sha = event === 'pull_request' ? payload.pull_request.head.sha : github.context.sha;
-  const job = process.env.GITHUB_JOB;
   const runId = parseInt(process.env.GITHUB_RUN_ID, 10);
 
   const referenceLink =
@@ -28,13 +27,13 @@ function buildSlackAttachments({ status, color, github }) {
       color,
       fields: [
         {
-          title: 'Workflow',
-          value: `<https://github.com/${owner}/${repo}/actions/runs/${runId} | ${workflow}>`,
+          title: 'Repo',
+          value: `<https://github.com/${owner}/${repo} | ${owner}/${repo}>`,
           short: true,
         },
         {
-          title: 'Job',
-          value: `<https://github.com/${owner}/${repo}/actions/runs/${runId} | ${job}>`,
+          title: 'Workflow',
+          value: `<https://github.com/${owner}/${repo}/actions/runs/${runId} | ${workflow}>`,
           short: true,
         },
         {