Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Unit tests for facts hash with topscope #22

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bastelfreak
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Feb 28, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (83477bc) 100.00% compared to head (0a59823) 100.00%.

❗ Current head 0a59823 differs from pull request most recent head adad156. Consider uploading reports for the commit adad156 to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##            master       #22   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines           10        10           
=========================================
  Hits            10        10           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bastelfreak
Copy link
Member Author

At a customer I discovered that no puppet-lint plugin fixes $::facts['some_component_module'] to $facts['some_component_module']. I thought we had a plugin for that. but it doesn't seem to be the case. Now is that a bug in topscope-variable-check or should that be handled by another plugin?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant