Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[warn] the "ssl" directive is deprecated, use the "listen ... ssl" directive instead (mailhost) #1284

Closed
rhykw opened this issue Dec 12, 2018 · 1 comment · Fixed by #1281

Comments

@rhykw
Copy link
Contributor

rhykw commented Dec 12, 2018

The ssl on syntax is deprecated since nginx 1.15.
We should only add it if we use nginx 1.14 or older.

A similar problem was reported as #1224.
This problem still remains in mailhost settings.

Affected Puppet, Ruby, OS and module versions/distributions

  • Puppet: all
  • Ruby: all
  • Distribution: all
  • Module version: 0.15.0

How to reproduce (e.g Puppet code you use)

class { 'nginx':
  manage_repo    => true,
  package_source => 'nginx-mainline',
  mail           => true,
}
nginx::resource::mailhost { 'domain1.example':
  auth_http   => 'server2.example/cgi-bin/auth',
  protocol    => 'smtp',
  listen_port => 587,
  ssl_port    => 465,
  starttls    => 'only',
  xclient     => 'off',
  ssl         => true,
  ssl_cert    => '/tmp/server.crt',
  ssl_key     => '/tmp/server.pem',
}

What are you seeing

What behaviour did you expect instead

Apply fix like #1225 to mailhost

Output log

2018/12/06 22:32:07 [warn] 25964#25964: the "ssl" directive is deprecated, use the "listen ... ssl" directive instead in /etc/nginx/conf.mail.d/domain1.example:13
2018/12/06 22:32:07 [warn] 25964#25964: the "ssl" directive is deprecated, use the "listen ... ssl" directive instead in /etc/nginx/conf.mail.d/domain1.example:37

Any additional information you'd like to impart

@rhykw
Copy link
Contributor Author

rhykw commented Dec 12, 2018

Fix in #1281

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant