dont deploy "ssl on" on nginx 1.15 or newer #1225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastelfreak
changed the title
bastelfreak
force-pushed
the
ssl
branch
2 times, most recently
from
8bbbe7d
to
75af0d5
Compare
ekohl
reviewed
Jul 7, 2018
manifests/params.pp
Outdated
| @@ -121,5 +121,13 @@ | |||
| $sites_available_group = $_module_parameters['root_group'] | |||
| $sites_available_mode = '0644' | |||
| $super_user = true | |||
| if fact('nginx_version') { | |||
| $add_listen_directive = versioncmp(fact('nginx_version'), '1.15.0') ? { | |||
There was a problem hiding this comment.
Isn't this equal to $add_listen_directive = versioncmp(fact('nginx_version'), '1.15.0') < 0?
There was a problem hiding this comment.
I has some issues in the past with versioncmp() when the first param is undef, that's why I wrapped it within the if statement.
There was a problem hiding this comment.
I meant the ? { ...} part. The full oneliner would be $add_listen_directive = !fact('nginx_version') or versioncmp(fact('nginx_version'), '1.15.0') < 0 but that's not really readable.
juniorsysadmin
approved these changes
Jul 7, 2018
fixes voxpupuli#1224. the option 'ssl on' within a server block is deprecated since nginx 1.15.0.
Rubueno
pushed a commit
to Rubueno/puppet-nginx
that referenced
this pull request
Oct 19, 2020
dont deploy "ssl on" on nginx 1.15 or newer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1224. the option 'ssl on' within a server block is deprecated since nginx 1.15.0.
Pull Request (PR) description
This Pull Request (PR) fixes the following issues