Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upstreams do not depend on package #942

Closed
jarro2783 opened this issue Oct 25, 2016 · 6 comments
Closed

Upstreams do not depend on package #942

jarro2783 opened this issue Oct 25, 2016 · 6 comments
Assignees

Comments

@jarro2783
Copy link

The nginx package resource should come before the upstreams. I see the following error in my logs:

Could not set 'file' on ensure: No such file or directory @ dir_s_rmdir - /etc/nginx/conf.d/restapi_pool-upstream.conf20161025-2146-tn3v2u.lock

It looks like the config files are trying to be written before the nginx package has installed /etc/nginx/conf.d. I can fix it in my own code by writing:

Class['nginx::package'] -> Nginx::Resource::Upstream <||>
@joshuaspence
Copy link

This seems to apply to other resources too, such as Nginx::Resource::Map.

@wyardley
Copy link
Collaborator

@jarro2783 @joshuaspence: can you try the most recent release?
I think between #906 and #933 (and possibly one other?) this may now be fixed. If you're still seeing this with 0.5.0, comment here, and I'll reopen.

@joshuaspence
Copy link

Nope, this is still an issue with 0.5.0. It looks like the problem was fixed for Nginx::Resource::Vhost, but not for Nginx::Resource::Upstream.

@wyardley
Copy link
Collaborator

wyardley commented Nov 2, 2016

@jarro2783 @joshuaspence: If you're willing / able, can you test out #958 (you can append .diff or .patch to the PR URL to get a patch of it, if that helps).

@jarro2783
Copy link
Author

As far as I can tell that solves it.

@wyardley
Copy link
Collaborator

wyardley commented Nov 4, 2016

Thanks @jarro2783. PR is now merged, so I'm going to close this issue for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants