Add location defaults to init and server resource #1071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
My goal is to avoid config_pitfalls. I'd like to clear the |
|
+1! |
|
This seems sane to me (though I'd love to see someone take a stab at reworking the configs in a way that avoids so much duplication in a cleaner way). @dol can you rebase? |
|
@dol I think the extra commit ends up pulling in other changes, so if possible, can you reset back, then rebase, then force push? |
dol
force-pushed
the
feature/locations_defaults
branch
2 times, most recently
from
cbebb3e
to
4c8865d
Compare
By adding location defaults it's possible to overwrite location value like 'index_files'.
dol
force-pushed
the
feature/locations_defaults
branch
from
4c8865d
to
cbafefb
Compare
|
@wyardley It took some time to get what you were asking for. But the merge commit is cleaned up. |
|
Looks good to me. Thanks :) |
cegeka-jenkins
pushed a commit
to cegeka/puppet-nginx
that referenced
this pull request
Sep 13, 2019
Add location defaults to init and server resource
Rubueno
pushed a commit
to Rubueno/puppet-nginx
that referenced
this pull request
Oct 19, 2020
Add location defaults to init and server resource
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By adding location defaults it's possible to overwrite location
value like 'index_files'.
Related to #1068