Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use hiera lookup function with feature toggle to merge resource hashes. #1116

Closed
wants to merge 1 commit into from

Conversation

archii
Copy link

@archii archii commented Aug 29, 2017

Addresses issue #614 - Hiera merge with multiple yaml files.

I've included a toggle parameter, $hiera_merge, to optionally enable this feature. This parameter defaults to false for backwards compatibility.

@wyardley
Copy link
Collaborator

Just wondering, since the Hiera v5 allows controlling the merge behavior more directly, is this still needed as a feature?
https://docs.puppet.com/puppet/5.1/hiera_merging.html#configuring-merge-behavior-in-hiera-data

@archii
Copy link
Author

archii commented Aug 29, 2017

lookup_options does seem to make this feature unnecessary. I'll close this PR.

Should issue #614 be closed with a relevant comment?

Thanks.

@wyardley
Copy link
Collaborator

@archii I'll close it. If you notice @igalic's comments there, it's still probably worth converting to lookup(), now that the module is P4 only, welcome to submit a PR for those changes if you'd like.

@archii archii deleted the merge-hiera-lookups branch August 30, 2017 01:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants