Add Debian 9 support #1200
Merged
Add Debian 9 support #1200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastelfreak
added
enhancement
bastelfreak
force-pushed
the
debian9
branch
3 times, most recently
from
ee0071a
to
1c631dc
Compare
ekohl
requested changes
Mar 25, 2018
spec/acceptance/class_spec.rb
Outdated
| it 'comes from the expected source' do | ||
| pkg_output = shell(pkg_cmd) | ||
| expect(pkg_output.stdout).to match pkg_match | ||
| # the passenger people package ngin, except for Debian 9 systems! |
spec/acceptance/class_spec.rb
Outdated
| pkg_output = shell(pkg_cmd) | ||
| expect(pkg_output.stdout).to match pkg_match | ||
| # the passenger people package ngin, except for Debian 9 systems! | ||
| unless fact('os.family') == 'Debian' && fact('os.release.major') == '9' |
There was a problem hiding this comment.
I'd prefer to change pkg_match above on Debian 9 to verify it comes from Debian itself. That makes this testing a bit more straightforward.
There was a problem hiding this comment.
sounds good, I will update it.
ekohl
approved these changes
Mar 25, 2018
|
Thanks! |
Closed
Rubueno
pushed a commit
to Rubueno/puppet-nginx
that referenced
this pull request
Oct 19, 2020
Add Debian 9 support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a rebase of #1154