Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rewrite_non_www_to_www option #1326

Merged
merged 2 commits into from
Jun 10, 2019
Merged

Add rewrite_non_www_to_www option #1326

merged 2 commits into from
Jun 10, 2019

Conversation

simmerz
Copy link
Contributor

@simmerz simmerz commented Apr 29, 2019

Pull Request (PR) description

This adds the opposing configuration to rewrite_www_to_non_www. Many site owners prefer (and this is not to get into the discussion of who is right or wrong) site urls to begin www. but also want a rewrite from non-www. for SEO purposes.

This PR adds rewrite_non_www_to_www, defaulting to false as per the existing param.

@puppet-community-rangefinder
Copy link

nginx::resource::server is a type

The enclosing module is declared in 9 of 575 indexed public Puppetfiles.

Breaking changes to this file WILL impact these modules (exact match):

Breaking changes to this file MAY impact these modules (near match):


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@dhoppe dhoppe added enhancement New feature or request tests-fail labels Apr 29, 2019
@dhoppe dhoppe removed the tests-fail label Jun 5, 2019
@dhoppe dhoppe requested a review from ekohl June 5, 2019 06:20
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps we should fail to compile if both rewrite_ options are true?

@simmerz
Copy link
Contributor Author

simmerz commented Jun 6, 2019

I'll update the PR. Great idea.

@simmerz
Copy link
Contributor Author

simmerz commented Jun 10, 2019

Perhaps we should fail to compile if both rewrite_ options are true?

That's pushed @ekohl - thanks for the feedback!

@bastelfreak bastelfreak merged commit e9fe1fe into voxpupuli:master Jun 10, 2019
@simmerz simmerz deleted the non_www_to_www_rewrite branch June 10, 2019 10:35
cegeka-jenkins pushed a commit to cegeka/puppet-nginx that referenced this pull request Sep 13, 2019
Rubueno pushed a commit to Rubueno/puppet-nginx that referenced this pull request Oct 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants