Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable SSL when requested #1327

Closed
wants to merge 1 commit into from
Closed

Enable SSL when requested #1327

wants to merge 1 commit into from

Conversation

zachfi
Copy link
Contributor

@zachfi zachfi commented May 2, 2019

Without this change, a true value on nignx::resource::server::ssl does not
result in the 'ssl on' directive necessary to enable SSL in some cases, like
IPv6. Here we include a fix to adhere to the user request to enable SSL for the
given nginx server.

Without this change, a true value on nignx::resource::server::ssl does not
result in the 'ssl on' directive necessary to enable SSL in some cases, like
IPv6.  Here we include a fix to adhere to the user request to enable SSL for the
given nginx server.
@zachfi
Copy link
Contributor Author

zachfi commented May 2, 2019

I think maybe this is just me not knowing the state of nginx.

@zachfi
Copy link
Contributor Author

zachfi commented May 2, 2019

This PR includes the ssl on in my config, but after upgrading 1.14.2_13,2 -> 1.16.0,2 I now see this warning in my nginx -t.

nginx: [warn] the "ssl" directive is deprecated, use the "listen ... ssl" directive instead in /usr/local/etc/nginx/sites-enabled/zleslie.info.conf:20

I guess its still a step in the right direction, but I need to read the nginx docs for a different PR to fix the listen lines, but probably someone will get to it before me.

@bastelfreak
Copy link
Member

Hi @xaque208, thanks for the PR. Can you please rebase this PR and also check #1330 ? That might address your issue here as well.

@bastelfreak bastelfreak added the needs-feedback Further information is requested label May 11, 2019
@dhoppe
Copy link
Member

dhoppe commented Jun 5, 2019

I will close this pull request, because this issue has been solved by #1330.

@dhoppe dhoppe closed this Jun 5, 2019
@zachfi zachfi deleted the sslenable branch June 5, 2019 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-feedback Further information is requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants