Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use more restrictive mode on temp paths #1443

Merged
merged 2 commits into from
Feb 2, 2021
Merged

Conversation

anarcat
Copy link
Contributor

@anarcat anarcat commented Feb 1, 2021

I get this on each run here:

Notice: /Stage[main]/Nginx::Config/File[/run/nginx/client_body_temp]/mode: mode changed '0700' to '0755'
Notice: /Stage[main]/Nginx::Config/File[/run/nginx/proxy_temp]/mode: mode changed '0700' to '0755'

It seems like nginx and this module have different opinions on the
correct mode for those directories. I believe Nginx is more correct,
and we should therefore follow it.

Note that this might apply to your module only if you have a global
File default resource defined.

Fixes: #1272

I get this on each run here:

Notice: /Stage[main]/Nginx::Config/File[/run/nginx/client_body_temp]/mode: mode changed '0700' to '0755'
Notice: /Stage[main]/Nginx::Config/File[/run/nginx/proxy_temp]/mode: mode changed '0700' to '0755'

It seems like nginx and this module have different opinions on the
correct mode for those directories. I believe Nginx is more correct,
and we should therefore follow it.

Note that this might apply to your module only if you have a global
File default resource defined.

Closes: voxpupuli#1272
@puppet-community-rangefinder
Copy link

nginx::config is a class

Breaking changes to this file MAY impact these 2 modules (near match):

This module is declared in 9 of 576 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@ekohl ekohl merged commit 63b75aa into voxpupuli:master Feb 2, 2021
@alexjfisher alexjfisher added the enhancement New feature or request label May 25, 2021
@alexjfisher alexjfisher changed the title use more restrictive mode on temp paths Use more restrictive mode on temp paths May 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

owner/group/mode change, normal?
4 participants