Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set X-Forwarded-Proto by default for reverse proxies #1462

Merged
merged 1 commit into from
Oct 4, 2021

Conversation

bruhadavid
Copy link
Contributor

…le behind proxy therefore it makes sense to add it to the defaults

Pull Request (PR) description

This Pull Request (PR) fixes the following issues

@puppet-community-rangefinder
Copy link

nginx is a class

Breaking changes to this file WILL impact these 15 modules (exact match):
Breaking changes to this file MAY impact these 34 modules (near match):

This module is declared in 9 of 578 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@ekohl ekohl changed the title Most of the software suites rely on HTTP_X_FORWARDED_PROTO header whi… Set X-Forwarded-Proto by default for reverse proxies Aug 17, 2021
@ekohl
Copy link
Member

ekohl commented Aug 17, 2021

I took the liberty of editing the PR title so it's readable. This makes sense to me. Let's see if the tests agree :)

@root-expert
Copy link
Member

Hey @bruhadavid, can you rebase with our master branch? That should fix failing specs.

@kenyon
Copy link
Member

kenyon commented Oct 4, 2021

I did the rebase.

@kenyon kenyon merged commit 96089f3 into voxpupuli:master Oct 4, 2021
@kenyon kenyon added the enhancement New feature or request label Oct 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants