Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for sieve protocol #1477

Merged
merged 1 commit into from
Oct 21, 2021
Merged

Conversation

tjikkun
Copy link
Contributor

@tjikkun tjikkun commented Oct 21, 2021

This is not in upstream nginx (yet), but is available at
https://github.com/AntagonistHQ/nginx/tree/sieve_v2

Pull Request (PR) description

This PR allows the word "sieve" to be used as a protocol. Upstream nginx doesn't support this, so I can understand if this PR gets denied for that. On the other hand, it is a very minor change so I am still hoping it gets accepted.

This is not in upstream nginx (yet), but is available at
https://github.com/AntagonistHQ/nginx/tree/sieve_v2
@puppet-community-rangefinder
Copy link

nginx::resource::mailhost is a type

that may have no external impact to Forge modules.

This module is declared in 9 of 578 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@b4ldr
Copy link
Member

b4ldr commented Oct 21, 2021

Upstream nginx doesn't support this, so I can understand if this PR gets denied for that. On the other hand, it is a very minor change so I am still hoping it gets accepted.

i'd probably allow it as it is really minor but looping in some of the more seasoned voxpupuli contributors for the ok

cc @bastelfreak @ekohl

@bastelfreak bastelfreak added the enhancement New feature or request label Oct 21, 2021
@bastelfreak bastelfreak merged commit c3d2ae6 into voxpupuli:master Oct 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants