Add create_resources for nginx_snippets

[aba-rechsteiner]

Pull Request (PR) description

add create_resources for nginx_snippets and nginx_snippets_defaults

[puppet-community-rangefinder]

nginx is a class

that may have no external impact to Forge modules.

This module is declared in 9 of 578 indexed public Puppetfiles.

---

These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

[kenyon]

Can you rebase to remove the merge commit? Also, can you add Puppet Strings docs for these new parameters?

[aba-rechsteiner]

Can you rebase to remove the merge commit? Also, can you add Puppet Strings docs for these new parameters?

sorry, sure i will adjust that

[kenyon]

The new parameter docs should go in the comments in init.pp. REFERENCE.md is automatically generated from those comments, which is called Puppet Strings documentation. https://puppet.com/docs/puppet/7/puppet_strings.html

[aba-rechsteiner]

i don't quite understand, other parameters like for example nginx_locations are also not described in init.pp

[root-expert]

i don't quite understand, other parameters like for example nginx_locations are also not described in init.pp

They aren't but they should have been. We are trying to add docs for every new parameter 😄

[root-expert]

I think it's ok to merge until we fix the CI.

[aba-rechsteiner]

@root-expert or @kenyon can you create a new v3.4.0 Release?